nystudio107 / craft-seomatic

SEOmatic facilitates modern SEO best practices & implementation for Craft CMS 3. It is a turnkey SEO system that is comprehensive, powerful, and flexible.
https://nystudio107.com/plugins/seomatic
Other
162 stars 68 forks source link

Unable to change SEO metafields after changing entry type #1464

Closed joelstrom closed 2 months ago

joelstrom commented 2 months ago

Describe the bug

We're unable to update SEO meta settings on a new entry after changing the entry type. Only way to get around it seems to be saving the entry once after changing the entry type.

To reproduce

Steps to reproduce the behaviour:

  1. Create new entry
  2. Change entry type to another one
  3. All metafields are "locked", editing them is not possible. Trying to override values is not possible.

Expected behaviour

Fields would be editable just like other custom fields in the entry type without having to save the entry in between

Screenshots

Creating new entry, everything looks normal:

Screenshot 2024-05-02 at 15 07 20

Changing entry type, fields get "locked":

Screenshot 2024-05-02 at 15 07 32

Versions

khalwat commented 2 months ago

I wasn't able to reproduce this.

In order to edit any of those disabled fields, you need to turn on the Override light switch above it.

Could it perhaps be that?

joelstrom commented 2 months ago

Using the override buttons don't seem to do anything in this state. After activating them, we're unable to open the dropdowns or manually enter anything into the plain text fields. As you can see in the screenshot below, the dropdowns are greyed out:

Screenshot 2024-05-03 at 9 38 59
khalwat commented 1 month ago

Are you seeing any errors in the JavaScript console? I tried reproducing what you're doing on the latest Craft 4.x and SEOmatic 4.x and was unable to

joelstrom commented 1 month ago

No javascript errors unfortunately! Was trying to keep an eye out on any failed requests too, but can't see see anything. The fields are in a disabled state and the value is what you see in the earlier screenshot also. Here is another where you see the html:

Screenshot 2024-05-13 at 17 32 36

It's not a huge issue especially for us, but the client gets the impression that something is breaking.

khalwat commented 1 month ago

Yeah I can understand the client's concern. I just wish I could replicate it here. It's tough to fix it without being able to replicate it. Any help you can offer would be welcome in that regard.