search

nystudio107 / craft-seomatic

SEOmatic facilitates modern SEO best practices & implementation for Craft CMS 3. It is a turnkey SEO system that is comprehensive, powerful, and flexible.
https://nystudio107.com/plugins/seomatic
Other
166 stars 71 forks source link

Installation of plugin fails with Campaign plugin already installed #1530

Closed joostwaaijer closed 3 weeks ago

joostwaaijer commented 3 weeks ago

Describe the bug

When trying to clean install the Seomatic plugin, I'm receiving an error that refers to a different plugin.

To reproduce

Steps to reproduce the behaviour:

  1. Install the Craft Campaign plugin (https://github.com/putyourlightson/craft-campaign)
  2. Install Seomatic plugin
  3. See the following error: failed to install seomatic: An error occurred while executing the "nystudio107\seomatic\migrations\Install migration: Calling unknown method: putyourlightson\campaign\models\CampaignTypeModel::getSiteSettings()

Expected behaviour

Seomatic installs without problem when combined with the Craft Campaign plugin.

Screenshots

image

Versions

khalwat commented 3 weeks ago

Interesting. It looks like the CampaignBehavior hasn't been added to the CampaignTypeModel yet.

Fixed in the above commits.

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop as 3.5.6”,

Then do a composer clear-cache && composer update

…..

Craft CMS 4:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v4 as 4.1.6”,

Then do a composer clear-cache && composer update

…..

Craft CMS 5:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-seomatic": "dev-develop-v5 as 5.1.6”,

Then do a composer clear-cache && composer update

joostwaaijer commented 3 weeks ago

Thank you! Seems to work now!