search

nystudio107 / craft-templatecomments

Adds a HTML comment with performance timings to demarcate `{% block %}`s and each Twig template that is included or extended.
https://nystudio107.com/
MIT License
20 stars 1 forks source link

Template Comments will sometimes screw up `<script>` #12

Closed hongc-cc closed 4 years ago

hongc-cc commented 4 years ago

Describe the bug

To be honest this is not urgent, or something that should be fixed at all. But i think i should drop it here for some comments.

Sometimes template comments insert profiling info into <script> might screw up the javascript. See attachment and console error:

  1. with templatecomments / devmode on Screenshot 2020-09-21 at 11 03 13 PM

  2. with templatecomments on / devmode off , or templatecomments off. Screenshot 2020-09-21 at 11 03 41 PM

hongc-cc commented 4 years ago

Resolved. Usually it shouldnt block the rendering.