Docker container names still use underscore; `up` conditional always fails

[ryanirelan]

Describe the bug

After the change to the Makefile to use hyphens in the container names instead of underscores, the conditional in theup command in the make file always evaluates false. The result is running something like make craft migrate/up shuts down the existing containers and spins up new ones.

I'm only working in the craft-vite branch currently. I haven't tested in other branches.

To reproduce

Steps to reproduce the behavior:

1. Create a new Craft project per the README instructions.
2. With the containers runnings, open a new terminal window and run make craft
3. See that the conditional evaluates to false and new containers spin up.

Expected behavior

I expect that the conditional would find the containers that are already running and run the craft command against them.

Screenshots

Versions

• Latest version of this repository in the craft-vite branch
• Docker Desktop 4.2.0 (runs Docker Engine 20.10.10)

[khalwat]

It looks like they changed it back, which is... annoying to say the least :)

[khalwat]

So this ends up being that they initially switched it to use the Docker Compose v2 (which uses -'s) and then switched _back_ to Docker Compose v1 (which uses_'s).

But it's now a preference in Docker desktop to turn on Docker Composer v2. So this can be fixed with a Docker preference setting:

Enable: Use Docker Compose V2 -- more here: https://docs.docker.com/compose/cli-command/