search

nystudio107 / generator-craftplugin

generator-craftplugin is a Yeoman generator for Craft CMS plugins
MIT License
74 stars 30 forks source link

Package names should be kebab-case #20

Closed brandonkelly closed 7 years ago

brandonkelly commented 7 years ago

The generated package name in composer.json should be a kebab-case'd version of the plugin name. Right now it's just all-lowercase without any spaces:

"name": "craftcms/elementapi",

should be:

"name": "craftcms/element-api",

(This is a matter of preference, but the convention among other Composer packages seems to be kebab-case.)

khalwat commented 7 years ago

hmmmm. Does this apply to the namespacing globally as well? e.g.: 

namespace craftcms/element-api;

vs.

namespace craftcms/elementapi;

Right now, it does the latter everywhere.

brandonkelly commented 7 years ago

Nope namespace should be lowercase w/out any spaces/hyphens/etc. This issue only affects package names.

khalwat commented 7 years ago

All set:

1.2.11 - 2017.02.14

Changed