search

nystudio107 / generator-craftplugin

generator-craftplugin is a Yeoman generator for Craft CMS plugins
MIT License
74 stars 30 forks source link

Module / Invalid paths #51

Closed H-i-red closed 6 years ago

H-i-red commented 6 years ago

bug2 bug1

H-i-red commented 6 years ago

I think it should be: 'basePath' => '@modules/stylemodule/translations' not: 'basePath' => '@stylemodule/translations'

H-i-red commented 6 years ago

And this: $this->sourcePath = "@modules/stylemodule/assetbundles/stylemodule/dist"; not: $this->sourcePath = "@stylemodule/assetbundles/stylemodule/dist";

codyjames commented 6 years ago

Good call @H-i-red. That fixed an issue for me.

khalwat commented 6 years ago

Really strange. This is something I definitely fixed/changed in the last release, I'm not sure how it got reverted. I even generated a module with it, and go the correct code.

Anyway, it's been fixed in 1.4.2:

https://github.com/nystudio107/generator-craftplugin/releases/tag/1.4.2

This is also live up on https://pluginfactory.io/