search

nystudio107 / instantanalytics

DEPRECATED Instant Analytics brings full Google Analytics support to your Twig templates and automatic Craft Commerce integration with Google Enhanced Ecommerce.
Other
101 stars 4 forks source link

Add to cart events still sent even when configured to not send data #8

Closed johndwells closed 7 years ago

johndwells commented 7 years ago

We're trying to avoid any commerce-related events being sent to GA while testing, by using the config/instantanalytics.php configuration file. But nothing we do seems to work (turning it off completely, turning it off in devMode, excluding servers, etc). We aren't using IA for general page views, but only for commerce impressions.

khalwat commented 7 years ago

yeah, grab it from the develop branch -- I fixed an issue where it wouldn't exclude properly.

johndwells commented 7 years ago

Thanks!

Sent from my iPhone

On 16 Dec 2016, at 19:23, khalwat notifications@github.com wrote:

Closed #8.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

khalwat commented 7 years ago

This is fixed in 1.1.4 (just released)

johndwells commented 7 years ago

:thumbsup: thanks!

On 20 December 2016 at 15:35, khalwat notifications@github.com wrote:

This is fixed in 1.1.4 (just released)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nystudio107/instantanalytics/issues/8#issuecomment-268273899, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIL3uYINtkOpSMJI9A5ia88H-d2OTwFks5rJ_W1gaJpZM4LPRXT .

-- Pura Vida John D Wells http://www.johndwells.com

khalwat commented 7 years ago

Technically, I fixed it in develop, broke it again in the 1.1.4 release, and then re-fixed it in the 1.1.5 release :)