nystudio107 / nginx-craft

An Nginx virtual host configuration for Craft CMS that implements a number of best-practices.
MIT License
310 stars 37 forks source link

Mitigate httpoxy vulnerability #2

Closed 3noch closed 7 years ago

3noch commented 7 years ago

According to https://www.nginx.com/resources/wiki/start/topics/examples/phpfcgi/ and https://httpoxy.org/, you should add this configuration to your ngnix config:

fastcgi_param HTTP_PROXY "";
khalwat commented 7 years ago

It looks like it's already there in the default fastcgi_params (which we include):

forge@nys-production /etc/nginx $ cat fastcgi_params | grep PROXY
fastcgi_param   HTTP_PROXY  "";
3noch commented 7 years ago

Ah but only for Forge. If anyone uses this on another provider they may not be so lucky. It'd be worth mentioning at least.

3noch commented 7 years ago

In fact, Forge is specifically designed for PHP so that makes sense. I know that Ubuntu does not include it.

khalwat commented 7 years ago

Good point! Added it -> https://github.com/nystudio107/nginx-craft