nystudio107 / nginx-craft

An Nginx virtual host configuration for Craft CMS that implements a number of best-practices.
MIT License
310 stars 37 forks source link

Duplicate `server_tokens` directive in vhost conf #31

Closed vidurb closed 3 years ago

vidurb commented 3 years ago

Describe the bug

The server_tokens directive appears twice in nginx-craft/sites-available/somedomain.com.conf in the 'Primary virtual host server block'.

To reproduce

Expected behaviour

This seems like an inadvertent error because both the server_tokens directives have the same value (off), so the expected behaviour would be to only have one directive and not fail nginx's config validation.

Screenshots

Error observed in CLI

Versions

iparr commented 3 years ago

I think I've tried to address this here: https://github.com/nystudio107/nginx-craft/pull/30

khalwat commented 3 years ago

Fixed thx