search

nystudio107 / retour

DEPRECATED Retour allows you to intelligently redirect legacy URLs, so that you don't lose SEO value when rebuilding & restructuring a website.
Other
168 stars 24 forks source link

changing an entry link from /url-1 to /url-2 to /url-1 shows both redirects in the redirects list #26

Closed joepagan closed 8 years ago

joepagan commented 8 years ago

Hi khal, Just trying your Retour plugin for the first time, so far appears to work great so thanks for your efforts in to making it! Just wanted to ask if there’s anything in there to deal with where a situation where the page is on /url-1, changes to /url-2, then back to /url-1, it appears at the moment that no redirect loop is happening and technically works absolutely fine, but I can see both the redirects in the dashboard still on the list at /admin/retour/redirects

khalwat commented 8 years ago

I'm on vacation atm, but I'll have a look when I get back (or when I get a chance). If anyone else can test this, that'd be helpful as well.

It should be deleting the redirect that would cause a redirect loop, there is logic in there to do it, but then it shouldn't be listed in the list of redirects.

khalwat commented 8 years ago

I think this might be fixed by the build checked into develop:

https://github.com/nystudio107/retour/tree/develop

khalwat commented 8 years ago

So I'm a bit flummoxed by this; are you still having an issue with it? Here's where it should be deleting the old redirect:

https://github.com/nystudio107/retour/blob/master/services/RetourService.php#L265