search

nytimes / Store

Android Library for Async Data Loading and Caching
Apache License 2.0
3.53k stars 305 forks source link

Clarify required dependencies for Store-Kotlin in README. #376

Closed ychescale9 closed 5 years ago

ychescale9 commented 5 years ago

Prior to AGP 3.3.x, only declaring the implementation 'com.nytimes.android:store-kotlin3:CurrentVersion' is enough as the required store classes in the core store module are also brought in.

Since AGP 3.3.x this no longer works as classes in the com.nytimes.android:store3 artifact can't be resolved unless adding implementation 'com.nytimes.android:store3:CurrentVersion' alongside the Kotlin dependency.

PR adds implementation 'com.nytimes.android:store3:CurrentVersion' in README.md for Store-Kotlin

Question: was com.nytimes.android:store-kotlin3:CurrentVersion intended to also bring in the com.nytimes.android:store3 dependency for the consuming module? If that's the case should we change apiElements project(':store') to api project(':store') in store-kotlin/build.gradle?

digitalbuddha commented 5 years ago

I don't see how it can be used without store, if you don't mind make the change in gradle.

ychescale9 commented 5 years ago

We are making the gradle change instead: https://github.com/NYTimes/Store/pull/380