search

nytimes / backbone.stickit

Backbone data binding, model binding plugin. The real logic-less templates.
MIT License
1.64k stars 176 forks source link

fix for issue #250 #280

Closed rwhitmire closed 9 years ago

akre54 commented 9 years ago

Great. Thanks for this. Few minor style tweaks then I'll merge.

kgodey commented 9 years ago

@akre54 @rwhitmire I just ran into this bug – any idea when it will be merged?

akre54 commented 9 years ago

I'm not super familiar with this part of the code, and I'm worried this hackiness will end up being brittle. I'll merge in just to save the headache. Tests like this are always good.

rwhitmire commented 9 years ago

The code in that section could definitely use some love. I spent about 2 hours trying to work around various events and this was the most reasonable thing I could come up with unfortunately.

Maybe a better fix would be to use view.listenTo so that the event is tied to each view as opposed to a single collection? I have no idea if that would work - just thinking out loud.

akre54 commented 9 years ago

No worries. If you get some time to clean up the implementation I'm happy to merge in a fix. Thanks for your hard work on this.

kgodey commented 9 years ago

Thanks @akre54 and @rwhitmire! Much appreciated.