search

nytimes / backbone.trackit

Manage unsaved changes in a Backbone Model.
202 stars 33 forks source link

Model events not firing on resetAttributes. #13

Closed neverthemachineforever closed 8 years ago

neverthemachineforever commented 10 years ago

Just wondering why the internal modal attributes object is manipulated directly instead of via clear / set? Backbone recommend that this object not be changed directly http://backbonejs.org/#Model-attributes

Currently this is affecting my model bindings via Backbone.ModelBinder as I believe it expects change events to fire.

adamyonk commented 10 years ago

Agreed! :+1:

kirach commented 9 years ago

:+1:

cipick commented 9 years ago

resolved here: https://github.com/NYTimes/backbone.trackit/pull/10 @delambo can you please merge this pull request?

delambo commented 8 years ago

merged #10