search

nytimes / collectd-rabbitmq

A collected plugin, written in python, to collect statistics from RabbitMQ.
https://collectd-rabbitmq.readthedocs.org/
Other
145 stars 79 forks source link

report overview stats #35

Closed redterror closed 8 years ago

redterror commented 8 years ago

N.B. - I don't even pretend to be a Python programmer, so I am likely doing dumb things. Needless to say, feedback is welcome.

This scratches my itch for getting overview stats about our rabbitmq cluster. I'm motivated by the fact that we use quite a lot of topic queues which aren't visible in the queue list (a good thing), so queue-level stats miss a lot of the traffic.

bobzoller commented 8 years ago

cheers @redterror -- I was about to start this work myself, so I'm tickled to see that you tackled it just a few days ago. I'm in devops and we're accountable for our rabbit's basic health, but care not about specific queues or exchanges. Watching the total number of messages in/out, # of consumers, etc is exactly what I need.

BTW the build failures look like a transient network error (I could be wrong).

redterror commented 8 years ago

I can replicate the failure here (managed to run the tests after submitting), so unlikely to be transient. Hopefully I can fix the tests and then provide the changes for a smoother merge.

redterror commented 8 years ago

1 travis test passed, the other failed. Help!

jimbydamonk commented 8 years ago

I looked into the failure. It is due to lint violations. You can test locally with make lint

flake8 collectd_rabbitmq tests collectd_rabbitmq/collectd_plugin.py:110:80: E501 line too long (83 > 79 characters) collectd_rabbitmq/collectd_plugin.py:111:80: E501 line too long (82 > 79 characters) collectd_rabbitmq/collectd_plugin.py:204:80: E501 line too long (102 > 79 characters) collectd_rabbitmq/collectd_plugin.py:208:80: E501 line too long (92 > 79 characters) collectd_rabbitmq/collectd_plugin.py:217:80: E501 line too long (100 > 79 characters) Makefile:49: recipe for target 'lint' failed make: *\ [lint] Error 1

redterror commented 8 years ago

I've rebased this and fixed the lint errors. What else can I do to encourage a merge? :)

jimbydamonk commented 8 years ago

Thanks @redterror I merged and cut a new release.

bobzoller commented 8 years ago

thank you both!

On Sat, Jun 25, 2016 at 3:32 AM, Mike Buzzetti notifications@github.com wrote:

Thanks @redterror https://github.com/redterror I merged and cut a new release.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NYTimes/collectd-rabbitmq/pull/35#issuecomment-228530393, or mute the thread https://github.com/notifications/unsubscribe/AABB0toaT_uV0HlGn0gZFZ4VNgtihxcfks5qPQO-gaJpZM4Io-Tg .