nytimes / drone-gke

Drone plugin for deploying containers to Google Kubernetes Engine (GKE)
https://open.nytimes.com/continuous-deployment-to-google-cloud-platform-with-drone-7078fe0c2eaf
Apache License 2.0
163 stars 35 forks source link

Add support for loading templates from remote locations #123

Open montmanu opened 4 years ago

montmanu commented 4 years ago

Is your feature request related to a problem?

Currently, the plugin requires that resource manifest templates exist on disk:

https://github.com/nytimes/drone-gke/blob/6ac83b93954ef35b0ff2d797b3f58e2d978aa975/main.go#L516-L524

This complicates sharing / re-use of templates.

Describe the solution you'd like

An ideal implementation would support loading of resource manifest templates from a remote location; similar to kubectl apply [-f|-k]

Describe alternatives you've considered

Current alternatives / workarounds include:

Additional context

Any implementation of this feature request should consider potential interactions with https://github.com/nytimes/drone-gke/issues/105 (i.e., how to load multiple templates from a remote location .. especially in the case of supporting directories as a valid argument)

tonglil commented 4 years ago

I think this should be done in from a separate step. That step can download any templates and concatenate them together for templating and application.