gziphandler: Implemented more informative errors (adammck's TODO)

nytimes / gziphandler

Go middleware to gzip HTTP responses

https://godoc.org/github.com/NYTimes/gziphandler

Apache License 2.0

868 stars 129 forks source link

gziphandler: Implemented more informative errors (adammck's TODO) #1

Closed ericlagergren closed 2 years ago

ericlagergren commented 9 years ago

gzip.go: Added a couple new types:

ErrorList, a slice of
KeyError, a small struct with the error and the content that caused the error
ErrEmptyContentCoding, an error if the Accept-Encoding header is empty
Function Append, which appends an ErrorList or KeyError to an
Function Error for both ErrorList and KeyError, which returns a formatted error string describing the error(s).

gzip_test.go: Added testing for errors

ericlagergren commented 9 years ago

Also, thanks for open sourcing this. We've found it very useful.

adammck commented 9 years ago

Thanks for the patch! If only all of my TODOs could be resolved by helpful internet strangers.

ericlagergren commented 9 years ago

@adammck No problem! I wish mine could as well... life would be great. When I saw the TODO I couldn't not spend a little time to give back. You saved me from having to write my own handler, which was awesome.