search

nytimes / gziphandler

Go middleware to gzip HTTP responses
https://godoc.org/github.com/NYTimes/gziphandler
Apache License 2.0
868 stars 129 forks source link

Expose acceptsGzip #34

Open wyattjoh opened 7 years ago

wyattjoh commented 7 years ago

I'd like to use this package with my custom web application wrapper, but I can't match the functionality provided by the NewGzipLevelHandler without the acceptsGzip function exposed: https://github.com/NYTimes/gziphandler/blob/fb3533722e14198abe471546c9798fd556531451/gzip.go#L174

adammck commented 7 years ago

I wouldn't be against making acceptsGzip/parseEncodings/parseCoding public, but we should move them to a subpackage if we do so. For the latter two, we might want to consider dropping our impl in favor of gddo/httputil/header.ParseAccept anyway, which would make the former trivial.

glasser commented 6 years ago

In general it's hard to use the exported GzipResponseWriter directly because of this issue but also because there's no way to set its options from outside the package.