search

nytimes / gziphandler

Go middleware to gzip HTTP responses
https://godoc.org/github.com/NYTimes/gziphandler
Apache License 2.0
868 stars 129 forks source link

Need pointer to implement CloseNotifier #63

Closed juliens closed 6 years ago

juliens commented 6 years ago

GzipResponseWriterWithCloseNotify doesn't implement CloseNotifier, but *GzipResponseWriterWithCloseNotify does.

Fix the tests to really verify with a request that accept gzip.

tmthrgd commented 6 years ago

You’d be better off changing CloseNotify to accept a value reciever instead. Doing that imposes no overhead, whereas this PR would add an extra allocation per request.

jprobinson commented 6 years ago

🌭 🍕 thanks!!