Add support for comparing by MIME.

nytimes / gziphandler

Go middleware to gzip HTTP responses

https://godoc.org/github.com/NYTimes/gziphandler

Apache License 2.0

868 stars 129 forks source link

Add support for comparing by MIME. #69

Closed meirf closed 6 years ago

meirf commented 6 years ago

zero API change; backwards compatible.
no change in time or space according to all the current benchmarks

Addresses https://github.com/NYTimes/gziphandler/issues/68

meirf commented 6 years ago

@tmthrgd ptal when you have a chance. (seems like you are most aware of the issues this PR addresses)

meirf commented 6 years ago

@jprobinson , I'm not totally sure what "approved" means in this context? Do I need to do anything or just wait until someone has approved and merged/committed?

jprobinson commented 6 years ago

I was out this afternoon and planned on merging in the morning. Didn't realize it was so urgent, @meirf.

meirf commented 6 years ago

Thank you all for reviewing!