Adds support for TinyMCE 4.x.x (Removes support from 3.x.x)

nytimes / ice

track changes with javascript

Other

1.71k stars 194 forks source link

Adds support for TinyMCE 4.x.x (Removes support from 3.x.x) #105

Closed NullVoxPopuli closed 4 years ago

NullVoxPopuli commented 10 years ago

Pull upstream (nytimes) master
Remove TinyMCE 3.5 related code
Changed folder structure of plugins to match that of TinyMCE 4.x.x

Only thing left (to my knowledge)

When building, the plugin files are named plugin.js instead of plugin.min.js (any help on that would be awesome)

delambo commented 10 years ago

Great work! Is anyone using this in production? It's hard to integration test against tinymce, and getting ice to adapt to new versions of tinymce has always been a huge pain.

johanneswilm commented 10 years ago

we don't, but we might in the near future.

dnaber-de commented 10 years ago

It would be nice to see this request merged, as WordPress ships the version 4 of TinyMCE since WordPress version 3.9. So contribution for WP support depends on this.

NullVoxPopuli commented 10 years ago

https://github.com/TinderBox is using this in production. :-)

andrew-kzoo commented 9 years ago

I'm hopeful about this plugin. Is it still being used and/or under active development at @NYTimes? I'd love to make use of it with @TinyMCE 4.x.x and to contribute fixes and updates. Thank you!

itmilos commented 8 years ago

@NullVoxPopuli Did you test this plugin tested on 4.3.x TinyMce?

NullVoxPopuli commented 8 years ago

@itmilos, I'm not sure. @jheth might be able to answer though?

jheth commented 8 years ago

@itmilos We are on 4.3.6 and continue to use this plugin. We have had to make a few tweaks to core tinymce over time but it has held up really well.

NullVoxPopuli commented 4 years ago

Cleaning up my PRs. If this work is still desired, feel free to cherry-pick