nytimes / ice

track changes with javascript
Other
1.71k stars 194 forks source link

Support for Froala editor? #133

Open Milaap opened 6 years ago

Milaap commented 6 years ago

Can ice be used with Froala editor? If yes, is there any documentation or code sample that can be used as a starting point?

We have tried to use it, but getting following error when a change is made in the editor:

Uncaught TypeError: Failed to execute 'setStart' on 'Range': parameter 1 is not of type 'Node'.
    at WrappedRange.rangeProto.setStart (ice.self.js?body=1:2201)
    at InlineChangeEditor._insertNode (ice.self.js?body=1:4173)
    at InlineChangeEditor.insert (ice.self.js?body=1:3607)
    at InlineChangeEditor.keyPress (ice.self.js?body=1:4887)
    at InlineChangeEditor.handleEvent (ice.self.js?body=1:3540)
    at HTMLDivElement.<anonymous> (ice.self.js?body=1:3391)
    at HTMLDivElement.dispatch (jquery.self.js?body=1:4666)
    at HTMLDivElement.elemData.handle (jquery.self.js?body=1:4334)
AhHa45 commented 6 years ago

this would be great