nytimes / library

A collaborative documentation site, powered by Google Docs.
https://nyt-library-demo.herokuapp.com/
Apache License 2.0
1.15k stars 144 forks source link

Resolve Circular Dependency #360

Closed afischer closed 1 year ago

afischer commented 1 year ago

Description of Change

This PR removes some longstanding circular dependencies in the app without modifying app behavior. It also rearranges some tests to better reflect the new location of these dependencies.

I believe server/list.js > server/docs.js > server/formatter.js is causing the issues, but eventually we should work towards getting rid of all of them.

Cycles to resolve:

Detected via npx madge --circular .

Related Issue

Towards #361

Motivation and Context

With the release of v1.5.0, this bug could cause headaches for users after upgrading.

Checklist