search

nytimes / libvmod-queryfilter

Simple querystring filter/sort module for Varnish Cache v3-v6
http://open.blogs.nytimes.com/
Other
17 stars 2 forks source link

hack to build against varnish 4.x dev package instead of source #4

Closed knan-nrk closed 6 years ago

knan-nrk commented 6 years ago

Hey. Just wanted to put this out there. As we only use the varnish 4.x variant of the mod at present, we've been using this hack to build against the upstream varnish-dev deb package for ubuntu instead of a source dir. (https://packagecloud.io/varnishcache/varnish41)

Won't work for varnish3 builds, since the VARNISH_VMOD* autoconf macros were introduced in the varnish 4 packaging.

The motivation is that I wanted to avoid rebuilding varnish from source to build this vmod.

Not at all expecting this to be applied, but use it as inspiration if you wish, if you're planning to drop varnish3 support.

andrew-canaday commented 6 years ago

@knan-nrk, acutally, this is great. Will see if I can integrate it with modifications for backwards conpatibility. As usual, the contribution is greatly appreciated!

Thanks!

andrew-canaday commented 6 years ago

@knan-nrk Just wanted to give you an update: A new version of libvmod-queryfilter is forthcoming which includees changes to support building from source or pre-built binaries and includes fixes for some issues which @gsdevme surfaced for us, also.

Integration with a CI pipeline is also in the works. If all goes well, they'll show up in the same release.

Thanks!

andrew-canaday commented 6 years ago

@knan-nrk I'm working on the 1.0 release this week and next (long time coming - apologies for the copious delays). Give the 1.0-prerelease branch a shot re: compiling against -dev packages, instead of source.

I've started on TravisCI, as well, and am going to look at potentially integrating some of the work started by @gsdevme. I aim to have it released a week from today, latest.

Thank you for your continued patience!