search

nytimes / openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications
Apache License 2.0
961 stars 98 forks source link

Resolution for #103: Support for HTTP PATCH operation #105

Closed sukidesuaoi closed 5 years ago

sukidesuaoi commented 5 years ago

Added HTTP Patch operation.

jprobinson commented 5 years ago

Hi @sukidesuaoi, you've added to the input test fixture but not the resulting output fixture (fixtures/cats.proto), which contain the expected protobuf specs. Please add the missing Protobuf specs so the tests pass. You can run this test this locally by running go test ./... in the base of the repo.

For details on which tests are failing, check out the Travis build: https://travis-ci.org/NYTimes/openapi2proto/builds/490369413

jprobinson commented 5 years ago

Thanks for adding the test fixture changes, @sukidesuaoi.

Is there some reason you've created a new openai2proto directory inside the project, though? It's broken pretty much everything. Please revert that change.

sukidesuaoi commented 5 years ago

Thanks for adding the test fixture changes, @sukidesuaoi.

Is there some reason you've created a new openai2proto directory inside the project, though? It's broken pretty much everything. Please revert that change.

I was doing the testing. hehe. I will revert the directory change.