Kubernetes OpenAPI spec compatibility

nytimes / openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications

Apache License 2.0

964 stars 98 forks source link

Kubernetes OpenAPI spec compatibility #129

Open curiousleo opened 4 years ago

curiousleo commented 4 years ago

Fixes #128 and #82.

Changes to make the Kubernetes fixture pass:

Ignore $ref declarations that are not strings
Allow primitive RPC return types
Update Kubernetes proto fixture

Additional changes:

Allow primitive RPC request types, for symmetry with the return type change

I'm mostly feeling my way around at this point. I haven't tested the changes other than running go test.

curiousleo commented 4 years ago

I don't really understand how kubernetes.proto was generated given that openapi2proto previously failed on kubernetes.json. So I'm not sure how valid it is to update kubernetes.proto here.

curiousleo commented 4 years ago

Feedback welcome. Ping @jprobinson @lestrrat (you commented on #82 and seem to have some context on this).

curiousleo commented 4 years ago

@jprobinson and @lestrrat seem to have moved on from NYT.

@JustinFullerNYT, do you have enough context on this project to provide feedback on this draft PR?

JustinFullerNYT commented 4 years ago

@jprobinson and @lestrrat seem to have moved on from NYT.

@JustinFullerNYT, do you have enough context on this project to provide feedback on this draft PR?

I can take a look and recruit some others to look as well!

tmc commented 2 years ago

@curiousleo / @JustinFullerNYT can we resurrect this?