search

nytimes / openapi2proto

A tool for generating Protobuf v3 schemas and gRPC service definitions from OpenAPI specifications
Apache License 2.0
964 stars 98 forks source link

Check availability of remote file #69

Closed lestrrat closed 6 years ago

lestrrat commented 6 years ago

This changes the tests to check for remote dependencies before running those tests.

fixes #68

jprobinson commented 6 years ago

Sorry, looks like I should have merged these PRs in a different order, mind fixing the imports failures in the test?

./proto_test.go:12:2: imported and not used: "github.com/pmezard/go-difflib/difflib"
./proto_test.go:174:12: undefined: diffmatchpatch
lestrrat commented 6 years ago

Well, you're in luck: I was just about to go to bed, but I can certainly do that after I fix this :)

lestrrat commented 6 years ago

@jprobinson done. it's working on my local machine, please do your thing once travis passes :)

lestrrat commented 6 years ago

@jprobinson Oh wait. something looks weid

lestrrat commented 6 years ago

@jprobinson this is good to go. #66 has been rebased on top of this PR, so you will need to merge this first

jprobinson commented 6 years ago

thankyousir!