search

nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

upgrade babel dependencies + config to support core-js@3 #125

Closed mckernanin closed 5 years ago

mckernanin commented 5 years ago

(likely a breaking change for core-js@2)

Fixes #119

mckernanin commented 5 years ago

Build is failing because core-js isn't installed/updated. Not sure if there's something special that needs to happen to update the peer dependency, I'm not super familiar with them.

mckernanin commented 5 years ago

Yep, adding it to the dependencies fixed the build. In master, core-js is in the lock file but not package.json. Is there a "right way" to do that, or just manually remove it from package.json?

tizmagik commented 5 years ago

I think having it as a peerDep is preferred in this case and then having it as a devDep would fix the build

mckernanin commented 5 years ago

Ah ok. Bumping the branch shortly.

tizmagik commented 5 years ago

Thanks @mckernanin I think I'll lump this with #124 so that we don't have 2 breaking releases back to back.

mckernanin commented 5 years ago

Sounds good, thanks!

tizmagik commented 5 years ago

Released as v7.0.0 🎉 Please holler (or open a new issue) if you see any problems.