search

nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

Don't lie to react about dependencies #144

Closed bgergen closed 4 years ago

bgergen commented 4 years ago

I think this accomplishes the dual purposes of not lying to react about dependencies while also preventing unwanted re-renders. All tests are passing, the linter is happy, and all looks well in the light manual regression testing I've done.

tizmagik commented 4 years ago

Thank you! This makes sense.

Can you also add the eslint hooks plugin? Can also be a separate PR

tizmagik commented 4 years ago

Oh I see this is based off my branch. Cool cool

bgergen commented 4 years ago

Yeah, you should be able to merge this into your branch and be good to go!