search

nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

forward ref is not working when using track as hoc #159

Closed shovalk closed 4 years ago

shovalk commented 4 years ago

while using track as hoc and setting in options forwardRef: true the ref is not being forwarded. The issue is reproduced and a relevant git repo can be found here - https://github.com/shovalk/react-tracking-forwardref-reproduce

tizmagik commented 4 years ago

Ah thanks for the bug report and reproduction case, @shovalk !

cc @ParadeTo who did the initial implementation (#153). Any ideas?

I'll try and take a closer look at this as soon as I get a chance as well.

Thanks again.

cpprookie commented 4 years ago

Looks like those commits merged into master but not published in npm package. Latest v7.3.0 was published in 2019. @tizmagik

tizmagik commented 4 years ago

Ah of course haha sorry! I thought I remembered releasing this, but I guess not. I'll cut a release and hopefully that should address this issue. Thanks @cpprookie !

tizmagik commented 4 years ago

This was released as v8.0.0 -- I verified it working with the reproduction repo @shovalk ! Give that a shot and let me know if you have any other issues. Thanks again @cpprookie !

cpprookie commented 4 years ago

Ah of course haha sorry! I thought I remembered releasing this, but I guess not. I'll cut a release and hopefully that should address this issue. Thanks @cpprookie !

Hah, never mind everyone makes mistake. Thanks for the awesome library, it's my pleasure that i could help community. @tizmagik

shovalk commented 4 years ago

@tizmagik Thank you!