Closed adi518 closed 3 years ago
Thanks, this is great! Do you mind also adding a note in the docs about the needed polyfills for older browser support moving forward after this change?
And yes, to answer your question, I think to be safe we will consider this a major breaking change.
Use Webpack 5 or Rollup to build an ESM output, which will make this library treeshakeable, saving some more KBs for consumers. I suggest trying TSDX for this.
Great idea. Happy to accept PRs for these as well (or at least an issue).
Sure, I'll update the readme.
core-js
was an issue we've been having as well! Please merge & release ASAP!
Yes, looking to do a release this week hopefully. I want to land #168 as semver minor in v8 first
@patrickskim @adi518 looks like #168 might not land this week so I've published this PR against @alpha
premajor release:
npm install react-tracking@9.0.0-0
Try it out and please post back with any issues you come across. Thanks!
@patrickskim @adi518 have you encountered any issues with this premajor?
I haven't pushed to production with the new version yet, but it's ongoing.
@tizmagik We were able to upgrade to react-tracking@9.0.0-0
in our gatsby project. It has been pretty seamless so far. Will update you if @patrickskim or I run into any issues! Thanks for this work π₯
v8.1.0 is released. I'll look to release a v9.0.0 next week or so with this change. Thanks again!
We are about two weeks in production with 9.0.0-0
and thus far, no issues.
RC v9.0.0-4 has been tagged, mind giving that a quick check and if all looks good I'll merge, tag and release this to mainline @adi518 @antciccone @patrickskim
npm install react-tracking@9.0.0-4
Removing core js make the bundle size much smaller. 15.3kb and 2.42 when gzip.
So far no issues, i will run the build on staging for a few days and wait the result.
Thank you for pushing this @tizmagik π
@tizmagik after few days of dogfooding and thus far, no issues. I think this release is good to go.
π’It π
Great, thanks @gedeagas !
Hey @bgergen do you think we can get CI going again? I'd love to have it test this PR before we merge/publish, if possible
@tizmagik Yes! I'll try to get that setup tomorrow. Sorry, I've been swamped today getting ready for Olympics coverage.
@tizmagik Working on figuring out why this isn't triggering a drone build. Maybe I missed something in the config to get it to run on a PR from a fork.
Thanks @bgergen -- feel free to push directly to this branch
Yay thank you everyone for all the hard work! π
This is now released as v9.0.0 thanks again all!
This PR removes
core-js
(ES polyfills) and leaves it outside the bundle of this package. Consumers should now add polyfills to their app if they need to support old browsers. I wonder whether it should be released as a new major version, WDYT?Other stuff this PR does:
@babel/cli
to latest minor (fixes some issues and adds--no-comments
flag).--minified
+--no-comments
) which lowers the bundle size even more.Next steps: Use Webpack 5 or Rollup to build an ESM output, which will make this library treeshakeable, saving some more KBs for consumers. I suggest trying TSDX for this.
PS, Babel CLI docs aren't super updated, so better run
yarn babel -h
to see the latest options.