search

nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

React 18 peer dependency #201

Closed aldrakos closed 2 years ago

aldrakos commented 2 years ago

Hello and thanks for the awesome job on this library!

Wanted to ask if there are any plans to support React 18, even just by adding the peer dependency and not fully opting in the new React18 features.

tizmagik commented 2 years ago

Sure yea, it should be fully compatible. PRs welcome!

aldrakos commented 2 years ago

Thanks! Will look into that then!

anna-rusk commented 1 year ago

@aldrakos Did you ever try out React 18? I am finding that it is not compatible

aldrakos commented 1 year ago

@aldrakos Did you ever try out React 18? I am finding that it is not compatible

How so? Latest versions have react18 as a peer dependency, and everything works smoothly.

anna-rusk commented 1 year ago

I filed an issue here - https://github.com/nytimes/react-tracking/issues/218

I just upgraded react and react-dom and didn't change any tracking code and am seeing this issue