nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

Switch to Github Actions #214

Closed tizmagik closed 1 year ago

tizmagik commented 1 year ago

Looks like open source Drone is no longer a thing...?

... and NYT doesn't allow GHA ... hmm

bgergen commented 1 year ago

Hmmm weird, I don't remember hearing anything about a change here. I can check in with folks to see what the recommended course of action is.

bgergen commented 1 year ago

@tizmagik Following up on this. Apparently there are major issues with Cloud Drone and DV is looking into alternatives (including GHA). I added myself as a watcher to their Jira ticket and there seem to be a number of other folks pressing them on this as well. I'll update here as soon as I hear more.

tizmagik commented 1 year ago

Great thanks for the update @bgergen !

bgergen commented 1 year ago

@tizmagik GitHub Actions are now supposedly enabled on this repo. Not sure how to test it though—maybe try pushing an empty commit to force the build to try to run again?

bgergen commented 1 year ago

@tizmagik Did it work? I'm not quite sure what I'm supposed to be seeing.

tizmagik commented 1 year ago

Hmm, doesn't look like it's triggering? Will try and take a closer look at this when I get a chance.

tizmagik commented 1 year ago

GHA still don't seem to be triggering? Maybe we could try merging this PR and then open a new one against that? I wonder if the workflow needs to be in main for it to trigger? 🤷

bgergen commented 1 year ago

GHA still don't seem to be triggering? Maybe we could try merging this PR and then open a new one against that? I wonder if the workflow needs to be in main for it to trigger? 🤷

Ohhhh that could certainly be the case. I say go for it and let's see what happens—if it still doesn't work I can bug DV to take a look at at the repo and let us know what we're missing.

tizmagik commented 1 year ago

@bgergen ha! chatgpt found the bug 😂 https://github.com/nytimes/react-tracking/pull/214/commits/faa372fa4dae6c30dc75c7850b595c3fa868c795

bgergen commented 1 year ago

omg