nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

Fix missing peerDeps #97

Closed tizmagik closed 5 years ago

tizmagik commented 5 years ago

We're missing some peerDeps as part of v5.5.0 (Babel 7 upgrade) in #94 ( cc @damassi )

MissingDependencyError
This package (or this version) uses `core-js/modules/es6.array.iterator`, 
`core-js/modules/es6.function.bind`, `core-js/modules/es6.function.name`, 
`core-js/modules/es6.object.assign`, `core-js/modules/es6.object.create`, 
`core-js/modules/es6.object.define-property`, `core-js/modules/es6.object.keys`, 
`core-js/modules/es6.object.set-prototype-of`, `core-js/modules/es6.promise`, 
`core-js/modules/es6.reflect.apply`, `core-js/modules/es6.reflect.define-property`, 
`core-js/modules/es6.symbol`, `core-js/modules/es7.symbol.async-iterator` and 
`core-js/modules/web.dom.iterable`, 
but does not specify them either as a dependency or a peer dependency

As reported by bundlephobia

damassi commented 5 years ago

See https://github.com/NYTimes/react-tracking/pull/98