search

nytimes / react-tracking

🎯 Declarative tracking for React apps.
https://open.nytimes.com/introducing-react-tracking-declarative-tracking-for-react-apps-2c76706bb79a
Other
1.88k stars 123 forks source link

Remove unneeded peerDep #99

Closed damassi closed 6 years ago

damassi commented 6 years ago

Ugh! one more, and hopefully the last! Sorry this wasn't caught. With preset-env and core-js importing exactly what's needed babel-runtime can be removed.

tizmagik commented 6 years ago

Ah, of course! I missed it too, no worries. Thanks!

I think we don't need the diffs from package-lock though (some dependencies look like they were downgraded). Can you remove that diff and then I'll merge this PR. Cheers!

damassi commented 6 years ago

Updated to move core-js into peerDeps and also ran npm install to update lockfile since deps have been changed.

tizmagik commented 6 years ago

v5.5.2 released -- thanks again for all your help @damassi :D

EDIT: Ah, I missed that it wasn't actually moved to peerDep -- no worries, v5.5.3 released :)