nytimes / redux-taxi

🚕 Component-driven asynchronous SSR in isomorphic Redux apps
Other
71 stars 8 forks source link

Add Prettier Pre-Hook #9

Closed frytyler closed 6 years ago

frytyler commented 6 years ago

Note this was closed and re-opened because of an issue with a merge.

As I was working on Jest test conversions I noticed small little inconsistencies with conventions so this PR is adding Prettier as a precommit hook.

The way it works is any js,json files that are staged will have prettier on them applied right before git commit is ran. It will clean up any small syntax issues to enforce a consistent convention. I set the pretty flags to my personal preference however that can be updated easily.

Prettier setup:

prettier --write --trailing-comma es5 --single-quote --tab-width 2

I would suggest getting a prettier package for whichever editor you are using and put Format on save on, however this will catch changes going forward.

All current .js, .json files have been prettiered.

Note Once #6 is merged this PR will be easier to remove.

Closes #8

tizmagik commented 6 years ago

@frytyler #6 was merged so now there's lots of whitespace conflicts in this PR. Mind rebasing?

frytyler commented 6 years ago

@tizmagik Working on it now.

frytyler commented 6 years ago

@tizmagik All good to go now, That was a rough resolve haha