search

nyu-devops-fall19-suppliers / suppliers

suppliers team repo
0 stars 1 forks source link

Authorizations Checker & Fix Update Display Error #173

Closed silemie closed 4 years ago

silemie commented 4 years ago

I fixed the authorization error in the previous version. Now all test cases are passed with 96% coverage.

image

Besides, I also found in swagger API the update operation didn't display. I fixed this error. Now our page is like that image

silemie commented 4 years ago

I also changed the 500 error handler test to the 401 error handler test. Because after refactoring our code should not meet any 500 errors and security checker might cause a 401 error. I did this change.

codecov-io commented 4 years ago

Codecov Report

Merging #173 into master will increase coverage by 4.26%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage   92.59%   96.85%   +4.26%     
==========================================
  Files           2        2              
  Lines         189      191       +2     
==========================================
+ Hits          175      185      +10     
+ Misses         14        6       -8
Impacted Files Coverage Δ
service/service.py 96.35% <100%> (+5.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 093eaab...3a3b3df. Read the comment docs.