hardcoded paths need to be fixed in nmt.py or train_nmt.py or both ?

nyu-dl / dl4mt-tutorial

BSD 3-Clause "New" or "Revised" License

618 stars 249 forks source link

hardcoded paths need to be fixed in nmt.py or train_nmt.py or both ? #34

Closed vince62s closed 8 years ago

vince62s commented 8 years ago

Can someone please tell me if we need to fix both files ?

making changes in train_nmt.py seems to be ok, but not sure.

can you help ? thanks.

orhanf commented 8 years ago

Hardcoded paths in nmt.py are just default parameters, and will be set to these default values only if you do not provide them in train_nmt.py. If you are specifying the paths, and the other parameters, in train_nmt.py then you don't need to change nmt.py