nyu-dl / dl4mt-tutorial

BSD 3-Clause "New" or "Revised" License
618 stars 249 forks source link

Unnecessary bias term? #67

Closed jozef-mokry closed 8 years ago

jozef-mokry commented 8 years ago

Is the bias term c_tt required here: (https://github.com/nyu-dl/dl4mt-tutorial/blob/master/session3/nmt.py#L458) ? I think the softmax that follows will cancel the effect of that bias.

orhanf commented 8 years ago

Hi @jozef-mokry , yes the bias term c_tt becomes obsolete but we keep it for backward compatibility (models trained before may cause problem with extra fields while loading)