search

nyu-mlab / pcap-parser

MIT License
1 stars 1 forks source link

Update to the script to detect OS and support Linux. #5

Closed billfitzgerald closed 6 months ago

billfitzgerald commented 6 months ago

This pull request updates parse.py to support both Linux and MacOS.

Specifically, it adds os detection, and then sets the path to tshark based on the OS.

I also added low_memory=False as a setting to correct for a Dtype error I encountered whyen processing test pcap files. There are nearly certainly more elegant ways to trap for and correct this error, but the low_memory setting allowed the parsing to complete with no errors/warnings, and the resulting data looked clean

This was tested in Ubuntu, with Python 3.7.

billfitzgerald commented 6 months ago

I see that there have been some updates to the script - let me know if you'd like me to update the pull request to not conflict with these changes.

billfitzgerald commented 6 months ago

Closing this pull request because #8 is a cleaner approach.