search

nyu-mll / jiant-v1-legacy

The jiant toolkit for general-purpose text understanding models
MIT License
21 stars 9 forks source link

[CLOSED] Rohan #1024

Closed jeswan closed 4 years ago

jeswan commented 4 years ago

Issue by rohjha Sunday Mar 01, 2020 at 22:35 GMT Originally opened as https://github.com/nyu-mll/jiant/pull/1024

rohjha included the following code: https://github.com/nyu-mll/jiant/pull/1024/commits

jeswan commented 4 years ago

Comment by pep8speaks Sunday Mar 01, 2020 at 22:35 GMT

Hello @rohjha! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 732:1: W293 blank line contains whitespace Line 733:1: W293 blank line contains whitespace Line 734:9: E303 too many blank lines (2)

Line 448:1: E302 expected 2 blank lines, found 1 Line 450:63: W291 trailing whitespace Line 451:1: W293 blank line contains whitespace Line 452:1: W293 blank line contains whitespace Line 549:62: E231 missing whitespace after ',' Line 586:1: E302 expected 2 blank lines, found 1 Line 588:59: W291 trailing whitespace Line 589:1: W293 blank line contains whitespace Line 605:57: E231 missing whitespace after ',' Line 648:1: E302 expected 2 blank lines, found 1 Line 651:101: E501 line too long (109 > 100 characters) Line 673:9: E306 expected 1 blank line before a nested definition, found 0 Line 747:1: E302 expected 2 blank lines, found 1 Line 3027:99: W291 trailing whitespace

You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.