Remove --remote_log from exp_fns.sh

nyu-mll / jiant-v1-legacy

The jiant toolkit for general-purpose text understanding models

MIT License

21 stars 9 forks source link

Open jeswan opened 4 years ago

jeswan commented 4 years ago

Issue by iftenney Thursday Apr 16, 2020 at 18:58 GMT Originally opened as https://github.com/nyu-mll/jiant/pull/1074

Allow running these if not on GCP. The log should still be in a text file in the console.

If running on Kubernetes, this flag doesn't matter anyway since k8s does its own log management.

iftenney included the following code: https://github.com/nyu-mll/jiant/pull/1074/commits

jeswan commented 4 years ago

Comment by sleepinyourhat Thursday Apr 16, 2020 at 19:04 GMT

LGTM. Approving as edge probing-specific.

jeswan commented 4 years ago

Comment by jeswan Thursday Sep 17, 2020 at 16:09 GMT

Are these changes still necessary? Planning to close all PRs to move jiant2 to this repo in the near future.