search

nyu-mll / jiant-v1-legacy

The jiant toolkit for general-purpose text understanding models
MIT License
21 stars 9 forks source link

[CLOSED] Switch to jsonl format for SNLI #1086

Closed jeswan closed 4 years ago

jeswan commented 4 years ago

Issue by W4ngatang Friday May 15, 2020 at 04:14 GMT Originally opened as https://github.com/nyu-mll/jiant/pull/1086

Addresses issue #1073. Also, externally will update the download link in scripts/download_glue_data.py to move the jsonl data to top-level where the task expects it to be.

W4ngatang included the following code: https://github.com/nyu-mll/jiant/pull/1086/commits

jeswan commented 4 years ago

Comment by pep8speaks Friday May 15, 2020 at 04:14 GMT

Hello @W4ngatang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 3776:101: E501 line too long (115 > 100 characters) Line 3780:101: E501 line too long (102 > 100 characters) Line 3816:101: E501 line too long (101 > 100 characters) Line 3817:101: E501 line too long (102 > 100 characters) Line 3880:21: E722 do not use bare 'except'

You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.

Comment last updated at 2020-05-20 04:22:13 UTC
jeswan commented 4 years ago

Comment by W4ngatang Friday May 15, 2020 at 04:16 GMT

I'm not that familiar with CircleCI. Tests are currently failing with No module named 'sklearn.utils.linear_assignment_'. Are tests broken on master right now, or did my data fix somehow break the libraries?

jeswan commented 4 years ago

Comment by pyeres Friday May 15, 2020 at 14:10 GMT

I'm not that familiar with CircleCI. Tests are currently failing with No module named 'sklearn.utils.linear_assignment_'. Are tests broken on master right now, or did my data fix somehow break the libraries?

Hey @W4ngatang — I triggered a re-run of the tests on master at HEAD here. The pipeline summary (see pipeline #2233) shows that master at HEAD passed tests 2 wks ago, and failed today with the exception you posted above. So it looks like this failure was not caused by your changes.

jeswan commented 4 years ago

Comment by W4ngatang Thursday May 21, 2020 at 04:26 GMT