search

nyu-mll / jiant-v1-legacy

The jiant toolkit for general-purpose text understanding models
MIT License
21 stars 9 forks source link

[CLOSED] [fix] Update the glue data script to use new download links #1112

Closed jeswan closed 4 years ago

jeswan commented 4 years ago

Issue by apsdehal Thursday Sep 03, 2020 at 18:24 GMT Originally opened as https://github.com/nyu-mll/jiant/pull/1112

We are in the process of update the download URLs of GLUE to FB hosted data files. This change updates the link in glue data download script.

Test Plan: Locally verified that the script is working.

apsdehal included the following code: https://github.com/nyu-mll/jiant/pull/1112/commits

jeswan commented 4 years ago

Comment by pep8speaks Thursday Sep 03, 2020 at 18:24 GMT

Hello @apsdehal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers: You can repair most issues by installing black and running: black -l 100 ./*. If you contribute often, have a look at the 'Contributing' section of the README for instructions on doing this automatically.

Comment last updated at 2020-09-03 18:26:26 UTC
jeswan commented 4 years ago

Comment by sleepinyourhat Thursday Sep 03, 2020 at 19:13 GMT

@jeswan: IIRC, jiant-dev has a similar script. Would you mind opening a PR to change the URLs there too?

jeswan commented 4 years ago

Comment by jeswan Thursday Sep 10, 2020 at 16:03 GMT

@sleepinyourhat Is https://nlp.stanford.edu/projects/snli/snli_1.0.zip still a valid URL for SNLI (nlp uses this URL)?

jeswan commented 4 years ago

Comment by sleepinyourhat Thursday Sep 10, 2020 at 16:13 GMT

Yep!

On Thu, Sep 10, 2020 at 12:03 PM jeswan notifications@github.com wrote:

@sleepinyourhat https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sleepinyourhat&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCzLyHdE8zgQwk2-sKwA1w&m=dLaT7ubIBU89SMaLs7ndQ8OC1e1YcNDM9D9UU8czbQQ&s=32-C8fXG-hnXackkV-D6xgy8EePJ3bOKQFuhxze_noU&e= Is https://nlp.stanford.edu/projects/snli/snli_1.0.zip https://urldefense.proofpoint.com/v2/url?u=https-3A__nlp.stanford.edu_projects_snli_snli-5F1.0.zip&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCzLyHdE8zgQwk2-sKwA1w&m=dLaT7ubIBU89SMaLs7ndQ8OC1e1YcNDM9D9UU8czbQQ&s=RGXsWI3729WEz4k70iTwobYgdWls8Q5Y0nZ7RJqWIko&e= still a valid URL for SNLI?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_nyu-2Dmll_jiant_pull_1112-23issuecomment-2D690407364&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCzLyHdE8zgQwk2-sKwA1w&m=dLaT7ubIBU89SMaLs7ndQ8OC1e1YcNDM9D9UU8czbQQ&s=V5t9csCb0mxn9aYdVxv-8zHhIowikVqUsyh8zztjmjo&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAJZSWJIT4MLXXFF2SK2XFDSFD2FVANCNFSM4QVKWSFA&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=sCzLyHdE8zgQwk2-sKwA1w&m=dLaT7ubIBU89SMaLs7ndQ8OC1e1YcNDM9D9UU8czbQQ&s=uiD0xZWkJZE6T3netRMvKAAXeevp6CDLV_ouK_WQbbo&e= .