search

nyu-systems / Grendel-GS

Ongoing research training gaussian splatting at scale by distributed system
Apache License 2.0
380 stars 20 forks source link

Find a bug while loading matrixcity dataset and fix it #23

Closed xinhao-luo closed 2 months ago

xinhao-luo commented 2 months ago

In scene/dataset_reader.py, line 268: with open(os.path.join(path, transformsfile)) as json_file:

Actually, the 'transformsfile' here is already a complete dataset path because of line 465: train_json_path = os.path.join(path, f"transforms_train.json")

So, os.path.join(path, transformsfile) will lead to a bug.

And just keep transformsfile here will be correct.

TarzanZhao commented 2 months ago

Thanks for pointing out!!