search

nyudlts / ultraviolet

UltraViolet 💜 is NYU Libraries' DLTS deployment of the InvenioRDM framework. All info in the link.
https://nyudlts.github.io/ultraviolet/
5 stars 5 forks source link

58 add commid to upload #187

Closed ekate closed 1 year ago

ekate commented 1 year ago

The request re-uses PR 185 but puts default community slug to invenio.cfg instead of the template

dismorfo commented 1 year ago

@ekate I'm almost done with my review of the pull request 186. Pull request 186 and this pull request are adding the same file invenio.cfg and similar update.

I think we should remove that change (adding invenio.cfg) from 186.

This pull request should be about the change to invenio.cfg (adding DEFAULT_COMMUNITY). I also suggest removing the file: templates/semantic-ui/invenio_app_rdm/users/uploads.html from this pull request and accepting pull request 185.

NOTE that 185 already includes the change requested by you in the last commit (reading the default community value from the configuration file)

ekate commented 1 year ago

@dismorfo that was a branch/PR to show you suggested change. I think we can will delete it.

dismorfo commented 1 year ago

@ekate I still think there is value in accepting this pull request with just the update to the file invenio.cfg

Would you like to do that? Or would you prefer to close this pull request and create a new pull request with the update to the file: invenio.cfg?

ekate commented 1 year ago

@dismorfo I will close that one and resubmit another one just for invenio.cfg as this one has issues with tests