search

nyurik / OsmWikibase

Wikibase customizations for OpenStreetMap
MIT License
1 stars 2 forks source link

Blind hack to make normalizePageName not throw an error #2

Closed Firefishy closed 1 year ago

Firefishy commented 1 year ago

See: https://github.com/nyurik/OsmWikibase/issues/1

Signed-off-by: Grant Slater github@firefishy.com

manicki commented 1 year ago

FWIW as I understand it, the intent of overriding the method was to always do Title::newFromText( $pageName )->getPrefixedText(); unlike in the parent class. As such, the "blind hack" seem to be the right solution, not only a hack.