Missing Handover failure trace sources from LTE in ns-3.38

Hi all,

I am going through the lte-enb-rrc.cc file of ns3-mmwave https://github.com/nyuwireless-unipd/ns3-mmwave/blob/new-handover/src/lte/model/lte-enb-rrc.cc to better understand the secondary cell handover implementation. While comparing to the original lte-enb-rrc.cc file of the ns-3.38 version, I noticed that there are some trace sources missing regarding handover failure (referenced below).

I was wondering whether these trace sources are relevant or not to the ns3-mmwave handover implementation, and whether this was the reason they are not part of the ns3-mmwave code. For example, when there is a handover failure in the mmWave cells, then the UE switches to the LTE eNB (recorded in the LteSwitchStats.txt to my understanding), so there is no need for generating such sources? Probably, I am missing some of the specifics of the secondary cell algorithm, so any insights are appreciated.

I understand that the current version of ns3-mmwave uses the ns-3.38 version of ns3, which normally includes these trace sources.

The trace sources are the following and can be found in lines 2107-2127 in this link https://gitlab.com/nsnam/ns-3-dev/-/blob/ns-3.38/src/lte/model/lte-enb-rrc.cc :

"HandoverFailureNoPreamble", 
"trace fired upon handover failure due to non-allocation of non-contention based "
"preamble at eNB for UE to handover due to max count reached"

"HandoverFailureMaxRach",
"trace fired upon handover failure due to max RACH attempts from UE to target eNB",

 "HandoverFailureLeaving",
"trace fired upon handover failure due to handover leaving timeout at source eNB",

"HandoverFailureJoining",
"trace fired upon handover failure due to handover joining timeout at target eNB",

Thank you

nyuwireless-unipd / ns3-mmwave

Missing Handover failure trace sources from LTE in ns-3.38 #273