Introduce has_velocity_dynamics

nyx-space / anise

ANISE provides a toolkit and files for Attitude, Navigation, Instrument, Spacecraft, and Ephemeris data. It's a modern replacement of the NAIF SPICE toolkit.

Mozilla Public License 2.0

68 stars 14 forks source link

Introduce has_velocity_dynamics #299

Closed gwbres closed 3 months ago

gwbres commented 3 months ago

Simple method to determine whether velocity/dynamics are present, which allows pos_vel() exploitation and helps determine whether full or partial rotation may apply

ChristopherRabotin commented 3 months ago

The tests fail because of some change I introduced the other day which should specifically prevent this. There's a specific BSP file that is stored in the secrets and only available to me as a maintainer, so I tried to skip the test if that env var isn't available. Obviously that does not work.

gwbres commented 3 months ago

The tests fail because of some change I introduced the other day

no worries 👍 I'm also thinking maybe this new method should simply be named has_velocity

ChristopherRabotin commented 3 months ago

I guess what I'm now wondering is whether your application could directly use state.vmag_km_s() > 0.0 directly? I have no strong opinions here.