search

nyx-space / nyx

Nyx is a high fidelity, fast, reliable and validated astrodynamics toolkit library written in Rust and available in Python
https://nyxspace.com
GNU Affero General Public License v3.0
147 stars 17 forks source link

Reenable WASM #296

Open ChristopherRabotin opened 2 months ago

ChristopherRabotin commented 2 months ago

Maintenance task description

I just disabled WASM to update a bunch of dependencies. I also don't know how much ANISE is compatible with WASM, and that's the biggest upcoming change (it takes a lot of work).

Scope of work

Uncomment the lines in the rust.yaml github workflow, and iterate on what needs fixing.

Priority

Low

TilBlechschmidt commented 2 months ago

At the very least, the core of ANISE seems to build for WASM (when excluding the metaload feature) 🙃

image

The main issue with the nyx main branch seems to be the zstd feature of parquet which attempts to build a native dependency. Disabling it does not cause a compilation failure (nyx builds successfully) but I suspect it will result in an inability to load zstd compressed files (would probably be fine for WASM).

ChristopherRabotin commented 2 months ago

Interesting, thanks. It may make sense to have a wasm specific build flag then, which disables the zstd feature of parquet.