Updates to drag units - Githubissues

nyx-space / nyx

Nyx is a high fidelity, fast, reliable and validated astrodynamics toolkit library written in Rust and available in Python

https://nyxspace.com

GNU Affero General Public License v3.0

198 stars 20 forks source link

Updates to drag units #298

Closed jake-asquith-spire closed 7 months ago

jake-asquith-spire commented 7 months ago

Updates to drag units to convert from ((kg km^2 s^-2) / m^1) to (kg km s^-2)

If this is a new feature or a bug fix ...

[x] Yes, the branch I'm proposing to merge is called fix-drag-units where #297 is the number of the issue.

ChristopherRabotin commented 7 months ago

Slide 7 of https://ccmc.gsfc.nasa.gov/RoR_WWW/SWREDI/2015/SatDrag_YZheng_060415.pdf agrees with this equation. And I agree with the unit conversion.

Thanks for the PR! I'll merge despite the macos build failing for some Python test -- I'm still working on a huge chunk of work to add SPICE/ANISE files to Nyx and I'll deal with those issues then.

jake-asquith-spire commented 6 months ago

Great, thanks! I meant to take a look at fixing that yesterday, but I didn't quite get the time. Thanks for merging 👍